fix(pages-router): only exclude top-level pages/api from page routing#3
Open
JaredStowell wants to merge 1 commit intomainfrom
Open
fix(pages-router): only exclude top-level pages/api from page routing#3JaredStowell wants to merge 1 commit intomainfrom
JaredStowell wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
globexclude predicate which compared basenames and unintentionally excluded any directory namedapiat any depth, dropping valid nested page routes likepages/blog/api/index.tsx.Description
scanPageRoutesglob usage to only exclude files/dirs that start with_via the function-form predicate, removing the blanketname === "api"check.pages/api/*entries (if (file === 'api' || file.startsWith(api${path.sep})) continue;) so nested*/api/*directories remain discoverable.tests/fixtures/pages-basic/pages/blog/api/index.tsxand a test assertion intests/routing.test.tsto cover discovery of nestedapidirectories.packages/vinext/src/routing/pages-router.ts,tests/routing.test.ts, and the new fixture file undertests/fixtures/pages-basic/pages/blog/api/index.tsx.Testing
npx vitest run tests/routing.test.ts, which passed:1 test file, 61 tests, 61 passed.Codex Task